-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reportQuestStep #126
reportQuestStep #126
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1.
Reviewable status: 0 of 3 files reviewed, 4 unresolved discussions (waiting on @trixie909)
src/Game/gamePlayReport.h
line 5 at r1 (raw file):
#include <math/seadVectorFwd.h> #include "KingSystem/System/PlayReportMgr.h" namespace ksys::qst {
can you add a newline before namespace
?
src/Game/gamePlayReport.cpp
line 9 at r1 (raw file):
#include "KingSystem/System/StageInfo.h" #include "KingSystem/Quest/qstQuest.h" namespace uking {
newline
src/Game/gamePlayReport.cpp
line 53 at r1 (raw file):
} } void reportQuestStep(const ksys::qst::Quest* quest, int step_index) {
add a newline after the }
src/Game/gamePlayReport.cpp
line 57 at r1 (raw file):
ksys::ProductReporter::getSomeBool(); const sead::SafeString quest_name = quest->mName;
I think you copied the mismatching/incomplete version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r4, 1 of 1 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @trixie909)
src/Game/gamePlayReport.cpp
line 57 at r1 (raw file):
Previously, leoetlino (Léo Lam) wrote…
I think you copied the mismatching/incomplete version?
sorry I was looking at an older commit, ignore this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Reviewed 2 of 2 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @trixie909)
added reportQuestStep
This change is